Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mult dep2 #1673

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Mult dep2 #1673

wants to merge 9 commits into from

Conversation

fieker
Copy link
Collaborator

@fieker fieker commented Nov 6, 2024

No description provided.

Try
  elementary_divisors(sparse_matrix(identity_matrix(ZZ, 2)))
without will give 3 EDs, the last one being 0
Needs further work on the Ge stuff and some of the internal
interface are bad.
Example
  k, a = wildanger_field(5,13);
  zk = lll(maximal_order(k))
  class_group(zk)
  h = zk.__attrs[:ClassGrpCtx]
  r = vcat(h.R_gen, h.R_rel);
  r = [x for x = r if isa(x, AbsSimpleNumFieldElem)]

  q = Main.MultDep.syzygies(r)

Then the rows of q are the relations
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 91.34615% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (4cb3cb9) to head (a59230a).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/NumField/NfAbs/MultDep.jl 92.15% 8 Missing ⚠️
src/Sparse/UpperTriangular.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   76.00%   75.94%   -0.07%     
==========================================
  Files         361      362       +1     
  Lines      113784   114150     +366     
==========================================
+ Hits        86483    86690     +207     
- Misses      27301    27460     +159     
Files with missing lines Coverage Δ
src/Map/NfOrd.jl 66.53% <100.00%> (-0.09%) ⬇️
src/Sparse/UpperTriangular.jl 0.00% <0.00%> (ø)
src/NumField/NfAbs/MultDep.jl 65.07% <92.15%> (ø)

... and 35 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant